Accomodate upcoming change in package Matrix (fixes #415) #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to working on this. A few comments:
ncol + 1
, wherencol
is anint
. Note thatncol
may take the valueINT_MAX
and in that casencol + 1
will overflow. The patch does not attempt to address this.R_alloc
somewhere, but maybe that is not idiomatic ... I needed to doa[i]++
and did not feel like checking whether that was legal fora
of typeIntegerVector
rather thanint *
...