Result of clone() now functional, fixes #34

Rct567 · Sep 14, 2023 · 1d6c060 · 1d6c060
1 parent 87f6b29
commit 1d6c060
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Rct567/DomQuery/DomQuery.php b/src/Rct567/DomQuery/DomQuery.php
@@ -645,7 +645,17 @@ public function filter($selector)
      */
     public function clone()
     {
-        return $this->createChildInstance($this->getClonedNodes());
+        $new_instance = self::create($this->getClonedNodes());
+
+        if (\is_bool($this->xml_mode)) {
+            $new_instance->xml_mode = $this->xml_mode;
+        }
+
+        if (isset($this->document) && $this->dom_xpath instanceof \DOMXPath) {
+            $new_instance->dom_xpath = $this->dom_xpath;
+        }
+
+        return $new_instance;
     }
 
     /**

diff --git a/tests/Rct567/DomQuery/Tests/DomQueryMiscellaneousElementMethodTest.php b/tests/Rct567/DomQuery/Tests/DomQueryMiscellaneousElementMethodTest.php
@@ -123,4 +123,22 @@ public function testEachIteration()
         $this->assertCount(2, $result);
         $this->assertInstanceOf(\DOMNode::class, $result[0]);
     }
+
+    /*
+     * Test clone
+     */
+    public function testClone()
+    {
+        $dom = new DomQuery('<div><p>My words</p></div>');
+        $elm = $dom->find('p');
+        $cloned_elm = $elm->clone();
+        $this->assertEquals('<p>My words</p>', (string) $elm);
+        $this->assertEquals('<p>My words</p>', (string) $cloned_elm);
+        $this->assertFalse( $elm->get(0)->isSameNode( $cloned_elm->get(0)) );
+
+        $dom_clone = $dom->clone();
+        $this->assertEquals('<div><p>My words</p></div>', $dom_clone);
+        $this->assertEquals('<p>My words</p>', $dom_clone->find('p')->first());
+        $this->assertTrue($dom_clone->find('p')->first()->is('p'));
+    }
 }