Skip to content

Commit

Permalink
Update Contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
arunsrinivasan committed Nov 12, 2014
1 parent 05650ab commit 4cd216f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Contributing.md
Expand Up @@ -18,7 +18,7 @@ Pull Requests
1. Please create all pull requests (PR) against the `master` branch.
2. Create **one PR per feature/bug fix**.
3. Create a branch for that feature/bug fix, and use that as a base for your pull requests. Pull requests directly against your version of `master` will not be accepted.
4. Unless there's a strong reason against, please squash all your commits together before issuing a PR, since you would be working on one issue.
4. Unless there's a strong reason against, please **squash all your commits together before issuing a PR**, since you would be working on one issue.
5. In your pull request's description, please state clearly as to what your PR does, i.e., what FR or bug your PR addresses, along with the issue number. For e.g, "Closes #717, rbindlist segfault on factor columns fixed and added tests."
6. All bug fixes and feature requests should also have **tests** added, to help catch any regressions while fixing another issue some time later. Tests should be added to `inst/tests/tests.Rraw` file.
7. The `README.md` file also has to be updated while fixing or implementing an issue. It should mention the issue number (along with the link) and what the issue is being closed. And also add a "Thanks to @your_name for the PR".
Expand Down

0 comments on commit 4cd216f

Please sign in to comment.