Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique argument for CJ #1148

Closed
eantonya opened this issue May 13, 2015 · 1 comment
Closed

unique argument for CJ #1148

eantonya opened this issue May 13, 2015 · 1 comment
Assignees
@arunsrinivasan
Labels
feature request
Milestone
v1.9.6

Comments

@eantonya
Copy link
Contributor

Since CJ is almost always used in combination with unique, I think it would make sense to add a unique argument to it, so that one can just write unique once:

CJ(unique(colA), unique(colB), unique(colC)) -> CJ(colA, colB, colC, unique = TRUE)

The default of unique should be specified via options, and imo should be set to TRUE after a few release iterations.
@jangorecki
Copy link
Member

Your suggestion to CJ in #814 looks interesting. Why don't you push suggested code together with handling this one. Even if it won't be mature PR it will be at least good reference/base to work with.

@arunsrinivasan arunsrinivasan added this to the v1.9.6 milestone May 28, 2015
@arunsrinivasan arunsrinivasan self-assigned this May 28, 2015
@jaapwalhout jaapwalhout mentioned this issue Jan 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunsrinivasan arunsrinivasan

Labels
feature request
Projects
None yet
Milestone
v1.9.6
Development

No branches or pull requests
3 participants
@eantonya @arunsrinivasan @jangorecki