Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] allow on= to work with both character vectors and lists #1257

Closed
dselivanov opened this issue Aug 10, 2015 · 2 comments
Closed

[Request] allow on= to work with both character vectors and lists #1257

dselivanov opened this issue Aug 10, 2015 · 2 comments
Assignees
@arunsrinivasan
Labels
feature request
Milestone
v1.9.8

Comments

@dselivanov
Copy link

From #1130 comments.
It would be nice if on= will accept both character vectors and lists as arguments.

DT1[DT2,  on = list(...) ]
# or 
DT1[DT2,  on = .(...) ]
# or 
DT1[DT2,  on = c(...) ]
@arunsrinivasan
Copy link
Member

Thanks @dselivanov.

@jangorecki
Copy link
Member

According to linked comments, particularly mentioned join on expression, the following issue is related joins on arbitrary functions #625.

@jaapwalhout jaapwalhout mentioned this issue Aug 21, 2015
Closed
@arunsrinivasan arunsrinivasan added this to the v1.9.8 milestone Sep 22, 2015
@arunsrinivasan arunsrinivasan modified the milestones: v2.0.0, v1.9.8 Mar 20, 2016
arunsrinivasan added a commit that referenced this issue Apr 6, 2016
@arunsrinivasan
Merge branch 'non-equi-joins'
adbf620 
* non-equi-joins:
  non-equi joins update to NEWS. #1452.
  Patching another issue spotted by Jan. Thanks!
  Update ?data.table with current non-equi join functionality.
  Limit number of combinations for tests to max of 100.
  Closes #1257, on=.() syntax is now possible.
  Added test for join on char type with op other than '=='.
  Allow only '==' operator for joins on char type.
  Free allocated variable.
  Fix for the issue @jan spotted. Added tests. Thanks Jan.
  Finally, non-equi joins NAs/NaNs correctly in all cases, hopefully.
  Added a note to self comment to nestedid.
  Minor: fix code spacing.
  Adding tests for non-equi joins only for non-NA/NaN cases.
  Fixing logic for NAs in i.
  Various improvements and fixes to nestedid.
  better logic fixes edge cases, also removes for-loop = ~3x faster
  Just fixing indentation and minor code cleanup. No implementations.
  thinko! should be seq_len, not seq_along.
  First stab at non-equi joins
@arunsrinivasan arunsrinivasan self-assigned this Apr 6, 2016
@mattdowle mattdowle modified the milestones: v1.9.8, v1.9.10 Nov 23, 2016
worker000000 pushed a commit to worker000000/data.table that referenced this issue Aug 13, 2017
@arunsrinivasan
Closes Rdatatable#1257, on=.() syntax is now possible.
5cceea5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunsrinivasan arunsrinivasan

Labels
feature request
Projects
None yet
Milestone
v1.9.8
Development

No branches or pull requests
4 participants
@mattdowle @arunsrinivasan @jangorecki @dselivanov