Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 method lookup found 'as.Date.IDate' on search path #4777

Closed
jangorecki opened this issue Oct 25, 2020 · 1 comment · Fixed by #4782
Closed

S3 method lookup found 'as.Date.IDate' on search path #4777

jangorecki opened this issue Oct 25, 2020 · 1 comment · Fixed by #4782
Milestone
1.13.4

Comments

@jangorecki
Copy link
Member

jangorecki commented Oct 25, 2020 •
edited by MichaelChirico
Loading

One of CRAN machines reports an issue caused by a workaround implemented to resolve #1500 in 4f6908a

  S3 method lookup found 'as.Date.IDate' on search path
  S3 method lookup found 'as.Date.IDate' on search path

According to changelog of zoo, their as.Date method has been changed in 1.8-1 (Jan 2018), so it is likely that workaround is no longer needed.
@jangorecki jangorecki added this to the 1.13.3 milestone Oct 25, 2020
@jangorecki
Copy link
Member Author

The fix for that is going to remove as.Date.IDate from search path. We could eventually postpone change to 1.14.0 but I doubt there are real world use cases for as.Date.IDate these days. It was introduced as a workaround almost 5 years ago, and AFAIU workaround is not needed anymore for almost 3 years.

@jangorecki jangorecki mentioned this issue Oct 27, 2020
Merged
TysonStanley added a commit that referenced this issue Dec 7, 2023
@TysonStanley
add method for IDate
4c09fb7 
Added `S3method(as.IDate, IDate)`. This is related to #4777 as discussed in NEWS.md.
jangorecki pushed a commit that referenced this issue Dec 8, 2023
@TysonStanley @jangorecki
add method for IDate
86bb492 
Added `S3method(as.IDate, IDate)`. This is related to #4777 as discussed in NEWS.md.
jangorecki added a commit that referenced this issue Dec 8, 2023
@jangorecki @TysonStanley
Pull 1.14.10 into master (#5814)
9b3b251 
* updated NEWS and urls

fixed url issues and added final details for patch release in news

* add method for IDate

Added `S3method(as.IDate, IDate)`. This is related to #4777 as discussed in NEWS.md.

* Add `setDTthreads(1)` to vignettes

To reduce runtime on building vignettes.

* reset setDTthreads at end of vignettes

* reset threads at end of vignettes

---------

Co-authored-by: Tyson Barrett <t.barrett88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.4
Development

Successfully merging a pull request may close this issue.

do not export as.Date.IDate anymore Rdatatable/data.table
1 participant
@jangorecki