Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If bit64 isn't loaded, print.data.table() should warn if there are any integer64 columns present. #975

Closed
mattdowle opened this issue Dec 1, 2014 · 3 comments

Comments

@mattdowle
Copy link
Member

Suggested by Stephen McInerney in person after Bay Area R User Group meetup, Nov 2014.

It's a simple if() and would avoid apparent "garbage/corruputed" data when in fact all that's needed is to require(bit64) for correct printing.

@arunsrinivasan
Copy link
Member

Trying the data linked in #810, this is what I get:

# Warning message:
# In fread("810_fread.txt") :
#   Some columns have been read as type 'integer64' but package bit64 isn't loaded. 
# Those columns will display as strange looking floating point data. There is no need to 
# reload the data. Just require(bit64) to obtain the integer64 print method and print the 
# data again.

What doesn't this warning address?

@mattdowle
Copy link
Member Author

Yes it seems this warning was already there for a long time, at least 2012.
I guess then, and combined with this report, the suggestion was to add a warning in the print method too. Maybe integer64 columns were loaded from disk, created some other way, or the fread() warning simply missed. The overhead of checking the class attribute of all columns when bit64 is not loaded, shouldn't be a speed concern since it's only printing.

@mattdowle mattdowle changed the title When fread reads integer64 it could warn if bit64 isn't loaded If bit64 isn't loaded, print.data.table() should warn if there are any integer64 columns present. Oct 21, 2015
@arunsrinivasan arunsrinivasan self-assigned this Oct 29, 2015
@arunsrinivasan
Copy link
Member

Fixed in commit 9362c4d. Closes #975.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants