Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various colClasses enhancements #2545

Merged
merged 51 commits into from
May 2, 2019
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
99cef9d
Merge remote-tracking branch 'refs/remotes/Rdatatable/master'
HughParsonage Dec 24, 2017
08e7cc6
Closes #2198
HughParsonage Dec 24, 2017
8fff141
Merge remote-tracking branch 'upstream/master'
HughParsonage Jan 3, 2018
c9a2312
Add tests for #1634
HughParsonage Jan 3, 2018
30c6b86
Fix tests 167 (ggplot2) which otherwise fail
HughParsonage Jan 3, 2018
aedd930
Fix platform-dependent tests (`\r\n` vs `\n`)
HughParsonage Jan 3, 2018
b0a7114
Check colClasses to be valid type. Closes #1634
HughParsonage Jan 3, 2018
6f9bc24
Revert omission of test on Windows
HughParsonage Jan 4, 2018
4f7e2d1
(Forgot this closing brace)
HughParsonage Jan 4, 2018
cd497b6
Re: Matt's review. Explain rationale of res167.
HughParsonage Jan 4, 2018
f50ac10
Close brace at end of test()
HughParsonage Jan 4, 2018
d543afc
Support colClasses, but as.raw problematic
HughParsonage Jan 5, 2018
d7c9937
Select/drop order respected with colClasses
HughParsonage Jan 6, 2018
ed66a74
Incorporate setfactor within set_colClasses
HughParsonage Jan 6, 2018
3af4ca1
Fix NULL colClasses
HughParsonage Jan 6, 2018
61b1a07
Slightly better commentary
HughParsonage Jan 6, 2018
de9da35
`vapply` should take `logical(1L)`
HughParsonage Jan 6, 2018
d3f351c
Add coverage, fix typos in fread.R
HughParsonage Jan 6, 2018
9a19044
Fix case colClasses is char and select unsorted
HughParsonage Jan 6, 2018
a382167
Use sprintf in warning messages
HughParsonage Jan 6, 2018
b128d9c
Update NEWS.md to be in sync with PR
HughParsonage Jan 6, 2018
68473ae
Add verbose option to colClasses, bugfix when select is character
HughParsonage Jan 6, 2018
96d93c3
Test typo fix
HughParsonage Jan 6, 2018
e51dd3e
Merge branch 'master' into master
mattdowle Jan 11, 2018
09d0739
Closes Issue 2025
HughParsonage Jan 11, 2018
09e8201
Merge branch 'master' of https://github.com/HughParsonage/data.table
HughParsonage Jan 11, 2018
500576b
Remove outer switch, only use list() type
HughParsonage Jan 16, 2018
49e670c
Single tryCatch in colClasses (cut 50 lines)
HughParsonage Jan 16, 2018
3f256bc
Rename set_colClasses (no longer ante)
HughParsonage Jan 16, 2018
d70e65e
Reclose #1445: non-monotonic select
HughParsonage Jan 16, 2018
1154851
Add comment explaining test
HughParsonage Jan 16, 2018
d30355b
Merge pull request #1 from HughParsonage/colClasses-valid-type-2545
HughParsonage Jan 16, 2018
a4b6c35
Closes #2025
HughParsonage Jan 16, 2018
eb84f8e
Reverse tryCatch to catch warnings
HughParsonage Jan 16, 2018
e5842bb
Merge pull request #2 from HughParsonage/colClasses-valid-type-2545
HughParsonage Jan 16, 2018
ccdf57c
Update NEWS and documentation for #2025
HughParsonage Jan 16, 2018
6c22aa8
Merge pull request #3 from HughParsonage/colClasses-valid-type-2545
HughParsonage Jan 16, 2018
546c75f
Use integers
HughParsonage Jan 25, 2018
32bddfd
Add commentary
HughParsonage Jan 25, 2018
6ee00a0
Merge branch 'master' into master
HughParsonage Apr 26, 2018
b7b647f
Merge branch 'master' into master
HughParsonage Aug 19, 2018
2d09126
Fix wrong inclusion
HughParsonage Aug 19, 2018
9fc22d9
Merge branch 'master' into master
mattdowle Oct 8, 2018
177215c
Merge branch 'master' into master
HughParsonage Nov 28, 2018
d1b0a04
Merge branch 'master' into master
mattdowle Apr 29, 2019
6530fcb
colClassesAs (which need as_ afterwards at R level, if any) returned …
mattdowle May 1, 2019
c6e2b72
passes tests locally
mattdowle May 1, 2019
9a54c6b
coverage
mattdowle May 1, 2019
3fe8be6
news item tidied and moved up
mattdowle May 1, 2019
a3ae6e7
tidy
mattdowle May 2, 2019
8ef1402
link added to news item
mattdowle May 2, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* Detects GB-18030 and UTF-16 encodings and in verbose mode prints a message about BOM detection.
* Detects and ignores trailing ^Z end-of-file control character sometimes created on MS DOS/Windows, [#1612](https://github.com/Rdatatable/data.table/issues/1612). Thanks to Gergely Daróczi for reporting and providing a file.
* Added option `logical01` to read a column of only `0`s and `1`s as `logical`, default `TRUE` for convenience in most cases. The large sample of rows throughout the file means that `fread` will be confident that the column really does just contain `0`s and `1`s, enabling and encouraging this convenient and efficient choice to save needing conversion afterwards or setting `colClasses` manually. In R, `logical` is `integer` anyway and can be treated as such in calculations. Further, it is no longer allowed to have mixed-case literals within a single column; i.e., a column of `TRUE/FALSE`s is ok, as well as `True/False`s and `true/false`s, but mixing different styles together is not.
* `colClasses` now emits a warning if an invalid/unsupported type is specified: [#1634](https://github.com/Rdatatable/data.table/issues/1634). Thanks to @hughparsonage for the pull request.
* Added ability to recognize and parse hexadecimal floating point numbers, as used for example in Java. Thanks for @scottstanfield [#2316](https://github.com/Rdatatable/data.table/issues/2316) for the report.
* Now handles floating-point NaN values in a wide variety of formats, including `NaN`, `sNaN`, `1.#QNAN`, `NaN1234`, `#NUM!` and others, [#1800](https://github.com/Rdatatable/data.table/issues/1800). Thanks to Jori Liesenborgs for highlighting and the PR.
* If negative numbers are passed to `select=` the out-of-range error now suggests `drop=` instead, [#2423](https://github.com/Rdatatable/data.table/issues/2423). Thanks to Michael Chirico for the suggestion.
Expand Down
Loading