no.dups argument to merge.data.table #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge.data.frame has now added an additional argument, no.dups, to handle cases where by.x != by.y && any(by.x %in% names(y)). The current version of merge.data.table was updated so that the 'suffixes' were added to both the by.x and y column in the joined data.table. However, base R have decided to only add the suffix to the column in Y for backwards compatibility.
Codecov Report
@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
+ Coverage 93.19% 93.19% +<.01%
==========================================
Files 61 61
Lines 12204 12205 +1
==========================================
+ Hits 11373 11374 +1
Misses 831 831
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the accepted PR #2631
On Saturday Feb 24th 2018 (NEWS) the corresponding patch for PR #2631 to base R
merge.data.frame()was merged into R-devel.In this update they have added a
no.dupsargument tomerge.data.frame(). WhenTRUE(default), this will add the correspondingsuffixesto column names inythat share a name withby.x.This pull request adds this argument and functionality to
merge.data.table()to make it consistent withmerge.data.frame(), replacing the behaviour of the accepted PR #2631 which mademerge.data.table()add suffixes to both theby.xandycolumns that shared a name.