Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFwrite gzip #3288
Merged
Fwrite gzip #3288
Conversation
and others
added 30 commits
Jan 12, 2019
Use zlib and gzopen/gzwrite/gzclose function to write buffer directly in a gzipped csv file. zlib is thread-safe and the gzip compression use the fwrite threads. Option compress="gzip" is added to fwrite et is automatically set when file ends with ".gz"
In fwrite, compress has now 3 options : * default : gzip if file ends with .gz, else csv * none : force csv * gzip : force gzip
Before this commit, every column is output one by one.
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
==========================================
+ Coverage 96.71% 97.01% +0.29%
==========================================
Files 66 66
Lines 12424 12475 +51
==========================================
+ Hits 12016 12102 +86
+ Misses 408 373 -35
Continue to review full report at Codecov.
|
…eclaration next to usage.
|
Fantastic PR -- thanks @philippechataignon. |
mattdowle
added a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #2016
Closes #2974
Closes #2612
I reopen a PR to discuss about its contents. Its a complete rewrite of #3278 : it doesn't use gzopen/gzwrite/gzclose because only one thread compress and that's slow.
In fwrite, output file is always open in binary mode. The idea is to take data from uncompressed buffer in normal case and to compress it and take data from compressed buffer when gzip is active. The code for managing file output is quite the same in normal and gzip mode.
The main difference concern the buffers :
Thanks for any advice on this PR.