Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch missing factor levels in rbindlist #3317

Merged
merged 1 commit into from Jan 26, 2019
Merged

Conversation

mattdowle
Copy link
Member

Closes #3315

@mattdowle mattdowle added this to the 1.12.2 milestone Jan 26, 2019
@MichaelChirico
Copy link
Member

I would try this directly with structure instead of relying on diff, since the behavior of diff might change upstream

@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #3317 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3317      +/-   ##
=========================================
+ Coverage    94.8%   94.8%   +<.01%     
=========================================
  Files          65      65              
  Lines       12094   12095       +1     
=========================================
+ Hits        11466   11467       +1     
  Misses        628     628
Impacted Files Coverage Δ
src/rbindlist.c 88.86% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5fb5c...64062fc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #3317 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3317      +/-   ##
=========================================
+ Coverage    94.8%   94.8%   +<.01%     
=========================================
  Files          65      65              
  Lines       12094   12095       +1     
=========================================
+ Hits        11466   11467       +1     
  Misses        628     628
Impacted Files Coverage Δ
src/rbindlist.c 88.86% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5fb5c...64062fc. Read the comment docs.

@mattdowle mattdowle merged commit 03894f0 into master Jan 26, 2019
@mattdowle mattdowle deleted the malformed_factor branch January 26, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants