-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast coalesce function for data.table #3608
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3608 +/- ##
==========================================
+ Coverage 98.24% 98.25% +0.01%
==========================================
Files 67 69 +2
Lines 12972 13088 +116
==========================================
+ Hits 12744 12860 +116
Misses 228 228
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments.
add some Rraw with examples, or put them in comments next to R code, so it is easier to reproduce.
we can think what we could parallelize here... we could eventually run all columns passed to ...
in parallel
I will push some helpers to new branch, which are likely to be useful here. |
#3609
cc(F)
x = sample(1e8)
any_na_integer(x)
cc(F)
x = list(sample(1e8), c(sample(1e8-1), NA), sample(1e8))
list_any_na_integer(x) anyNA would be best to incorporate into core loop in update: #3608 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more detailed feedback
I reduced number of passes over
|
|
|
Should long vectors be supported? |
@HughParsonage in the long run they should but I was not able to code |
some benchmarking of Matt's approach (strictly single pass handling everything) vs single pass |
Closes #3424
Timings using script https://gist.github.com/MichaelChirico/3ed5276838e9114f89a607594e101ab2
logical
column:integer
column:numeric
column:character
column: