Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsum works on int64 column, closes #1647 #3464 #3737

Merged
merged 3 commits into from Aug 14, 2019
Merged

gsum works on int64 column, closes #1647 #3464 #3737

merged 3 commits into from Aug 14, 2019

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Jul 31, 2019

closes #1647
closes #3464

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #3737 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3737      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          71       71              
  Lines       13160    13199      +39     
==========================================
+ Hits        13083    13122      +39     
  Misses         77       77
Impacted Files Coverage Δ
src/gsumm.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a00de...43c99c4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #3737 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3737      +/-   ##
==========================================
+ Coverage   98.81%   98.81%   +<.01%     
==========================================
  Files          69       69              
  Lines       13285    13324      +39     
==========================================
+ Hits        13127    13166      +39     
  Misses        158      158
Impacted Files Coverage Δ
src/gsumm.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2986736...0b5d251. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Aug 13, 2019
@mattdowle mattdowle merged commit a8e926a into master Aug 14, 2019
@mattdowle mattdowle deleted the gsum-int64 branch August 14, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gsum on int64 ignores na.rm=FALSE Inaccurate sum of integer64 returned using by clause
2 participants