non-character-allNA done directly rather than tricking BODY #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangorecki
reviewed
Sep 30, 2019
…BODY approach in this PR, and dogroups zero-copy-coerce enabled to reach this test
Codecov Report
@@ Coverage Diff @@
## master #3923 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 72 72
Lines 13552 13547 -5
=========================================
- Hits 13471 13466 -5
Misses 81 81
Continue to review full report at Codecov.
|
jangorecki
reviewed
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3909
On balance I figured it was clearer to do the two cases directly (hopping via 'where' or not) to assign the NA_STRING rather than tricking the BODY macro.
Plus some formatting.