Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CsubsetDT callable from C from in other packages #4084

Merged
merged 5 commits into from
Dec 17, 2019
Merged

make CsubsetDT callable from C from in other packages #4084

merged 5 commits into from
Dec 17, 2019

Conversation

lsilvest
Copy link
Contributor

@lsilvest lsilvest commented Nov 30, 2019

Closes #3751.

@jangorecki
Copy link
Member

jangorecki commented Dec 1, 2019

Thanks for PR. I added some documentation. For future PRs please create new branch rather than commiting to master (even if it is just master in your fork). Ideally push it to Rdatatable repo directly, if you are not a member yet @mattdowle should add you soon.

@lsilvest
Copy link
Contributor Author

lsilvest commented Dec 1, 2019

Sure, will make sure I create a new branch. Thanks for incorporating this!

@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #4084 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4084      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          72      72              
  Lines       13675   13676       +1     
=========================================
+ Hits        13594   13595       +1     
  Misses         81      81
Impacted Files Coverage Δ
src/init.c 100% <100%> (ø) ⬆️
src/subset.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f17d18...19dd7da. Read the comment docs.

@mattdowle
Copy link
Member

mattdowle commented Dec 17, 2019

Thanks, @lsilvest! I invited you to be project member; you'll need to accept the invitation button that Github shows on your profile or repositories page. Once you accept you'll be able to create branches in main project for next time.
I'll do a quick follow up commit after merge to move the news item up and add you to DESCRIPTION contributors.

@mattdowle mattdowle merged commit 02789dc into Rdatatable:master Dec 17, 2019
mattdowle added a commit that referenced this pull request Dec 17, 2019
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make 'CsubsetDT' callable from C in other packages
3 participants