-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if R CMD SHLIB can compile OpenMP directly #4374
check if R CMD SHLIB can compile OpenMP directly #4374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @kevinushey for this PR.
Works fine on my local Xubuntu.
GitLab pipeline (unfortunately we don't have Mac build there yet #3326) revealed that clean up is not working good enough:
* checking if this is a source package ... NOTE
Found the following apparent object files/libraries:
test-omp.o
Object files/libraries should not be included in a source package.
* checking top-level files ... NOTE
Non-standard file/directory found at top level:
‘test-omp.o’
@mattdowle could you please invite Kevin to our members group, so he can push directly to Rdatatable/data.table branches?
Codecov Report
@@ Coverage Diff @@
## master #4374 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 73 73
Lines 14104 14104
=======================================
Hits 14049 14049
Misses 55 55 Continue to review full report at Codecov.
|
Thanks, @kevinushey! As Jan suggested, I've invited you to be project member, and will add you to contributors list. |
… suggested to pass checkbashisms; #4374
Part of #4348.
The intention here is that if the user has already modified
src/Makevars
such that OpenMP "just works", then that should be detected by explicitly validating thatR CMD SHLIB
can compile with OpenMP.This allows
data.table
to compile using OpenMP for me when using the following Makevars:Asking whether we can set those flags (or similar) in R 4.0.0 is a separate question, I think.