-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all.equal dispatches to column methods #4546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4546 +/- ##
==========================================
+ Coverage 97.53% 99.61% +2.07%
==========================================
Files 80 73 -7
Lines 14916 14105 -811
==========================================
- Hits 14548 14050 -498
+ Misses 368 55 -313 ☔ View full report in Codecov by Sentry. |
any idea if this can be a breaking change for any proper use of all.equal? |
I tried to guard against that but I can't say for 100% certain... perhaps best to slip this release |
how is this related to rbindlist? I think you wanted to link #4543 @MichaelChirico |
Yes thanks @jangorecki |
I think this can be included in 1.16.0 👍 |
Generated via commit e324926 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 6 seconds Time taken to run |
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
It might be preferable to split off the test fixes that are not specifically related to this PR (but were identified as bugs by the code changes here); let me know. |
Nice! Change looks good, but I think the broken tests warrant a NEWS item now (also since there is a slight change of behavior). |
Oh, good catch. It needed a NEWS item anyway. |
Closes #4543
A bit clunky, open to suggestions for other ways to solve #4543 and also keep test 1710.5.
The improvement here has flushed out some really long-time broken tests in our suite of two flavors:
all.equal.numeric()
PoV. Really obvious mismatches were not caught.fwrite()
retains sub-second representations vs. not.Overall I think this is a really nice catch by this PR & glad the suite is improved.