Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coerceAs applied to fill in dcast #4586

Merged
merged 39 commits into from
Mar 4, 2024
Merged

coerceAs applied to fill in dcast #4586

merged 39 commits into from
Mar 4, 2024

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jul 1, 2020 •
edited
Loading

Closes #4561

jangorecki and others added 27 commits May 24, 2020 01:15
@jangorecki
nafill rework for more robust coerce
196f420
@jangorecki
initial change for #4101
1fa2069
@jangorecki
nafill simple fill coerce
22f98f7
@jangorecki
nafill const works for locf and nocb as well, closes #3594
7747c3d
@jangorecki
fix tests for #4101
cc2cc0e
@jangorecki
coverage
4dfa307
@jangorecki
placeholder for nafill #3992
5c1fa6b
@jangorecki
use coerceAs in froll
7e8331d
@jangorecki
enable disabled test
ff5aed2
@jangorecki
nafill retain names, tests for fill list
0bf1564
@jangorecki
coerceAs gets copyArg so now can return its input
db00097
@jangorecki
better control of verbose, and better find class for coerceAs
d0ecba4
@jangorecki
proper verbose to int
be8347b
@jangorecki
verbose changes coverage
b648661
@jangorecki
rm unused anymore
008b37c
@jangorecki
more precise verbose arg check
07c9d2d
@jangorecki
memrecycle escape warnings and simple verbose for numcol==0
9467ff5
@jangorecki
coerceAs does not emit extra warning anymore
1edae4f
@jangorecki
coerceAs verbose, more tests
71ab119
@jangorecki
use older nanotime api
858d7a7
@jangorecki
update error msg
a2f9adc
@jangorecki
coverage
df758a6
@jangorecki
codecov of coerceAs
45e26db
@jangorecki
catch all verbose
98f7cd3
@jangorecki
Revert "initial change for #4101"
834afba 
This reverts commit 1fa2069.
@jangorecki
Revert "fix tests for #4101"
f2ef980 
This reverts commit cc2cc0e.
use coerceAs in fcast.c
db95b08
@jangorecki jangorecki mentioned this pull request Jan 2, 2021
Closed
@MichaelChirico MichaelChirico marked this pull request as draft December 14, 2023 11:18
@MichaelChirico MichaelChirico marked this pull request as ready for review February 20, 2024 07:53
@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Feb 20, 2024
MichaelChirico
MichaelChirico commented Feb 20, 2024
View reviewed changes
inst/tests/tests.Rraw Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (1822d35) to head (9d7b196).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4586   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          80       80           
  Lines       14861    14861           
=======================================
  Hits        14488    14488           
  Misses        373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

Pulling in @tdhock given similar #5549

@MichaelChirico MichaelChirico mentioned this pull request Feb 22, 2024
Merged
@MichaelChirico MichaelChirico mentioned this pull request Mar 1, 2024
Merged
tdhock
tdhock approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelChirico MichaelChirico merged commit 46ee525 into master Mar 4, 2024
5 checks passed
@MichaelChirico MichaelChirico deleted the dcast-int64 branch March 4, 2024 20:39
@tdhock tdhock mentioned this pull request Mar 5, 2024
Closed
@MichaelChirico MichaelChirico mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhock tdhock tdhock approved these changes

@jangorecki jangorecki jangorecki approved these changes

@mattdowle mattdowle Awaiting requested review from mattdowle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

dcast on missing int64 value generates 9218868437227407266 instead of NA
3 participants
@MichaelChirico @tdhock @jangorecki