Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain PKG_* user-supplied env values #4735

Merged
merged 2 commits into from Oct 3, 2020
Merged

retain PKG_* user-supplied env values #4735

merged 2 commits into from Oct 3, 2020

Conversation

mattdowle
Copy link
Member

Closes #4664

Aside: I removed the quotes around "${CC}" "${CFLAGS}" on line 88 because I got an incidental error gcc -std=gnu99: not found when I was testing. Removing those quotes made that error go away.

Shame we can't use += in Makevars. It would be nice to know which system's make do not support +=, just Solaris? Note that WRE note 70 states

[+=] was apparently introduced in SunOS 4, and is available elsewhere provided it is surrounded by spaces.

I don't know how SunOS 4 relates to Solaris. And does "elsewhere" mean "everywhere else"? Perhaps WRE is close to allowing +=.

@mattdowle mattdowle added this to the 1.13.1 milestone Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #4735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4735   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          73       73           
  Lines       14539    14539           
=======================================
  Hits        14458    14458           
  Misses         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5afd2...318d867. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop "blowing away" user-supplied PKG_* flags
1 participant