new translations for upcoming release #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
added
the
translation
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 73 73
Lines 14556 14556
=======================================
Hits 14480 14480
Misses 76 76
Continue to review full report at Codecov.
|
|
About 20 translations we rely on our team for, have sent out an ask. |
MichaelChirico
commented
Oct 17, 2020
| @@ -501,7 +501,7 @@ SEXP forder(SEXP DT, SEXP by, SEXP retGrpArg, SEXP sortGroupsArg, SEXP ascArg, S | |||
| int keyAlloc = (ncol+n_cplx)*8 + 1; // +1 for NULL to mark end; calloc to initialize with NULLs | |||
| key = calloc(keyAlloc, sizeof(uint8_t *)); // needs to be before loop because part II relies on part I, column-by-column. | |||
| if (!key) | |||
| STOP("Unable to allocate %"PRId64" bytes of working memory", (uint64_t)keyAlloc*sizeof(uint8_t *)); // # nocov | |||
| STOP(_("Unable to allocate %"PRIu64" bytes of working memory"), (uint64_t)keyAlloc*sizeof(uint8_t *)); // # nocov | |||
There was a problem hiding this comment.
@mattdowle this fix is correct right?
There was a problem hiding this comment.
@MichaelChirico oh yes, good spot!
jangorecki
reviewed
Oct 19, 2020
|
If it is ready to merge we could have it now for a hot fix needed due to #4769, adding milestone |
|
yes it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4764
translations courtesy @hongyuanjia