Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programming vignette tweak #5010

Merged
merged 4 commits into from May 23, 2021
Merged

programming vignette tweak #5010

merged 4 commits into from May 23, 2021

Conversation

jangorecki
Copy link
Member

No description provided.

@jangorecki jangorecki added this to the 1.14.1 milestone May 18, 2021
@jangorecki jangorecki changed the title docs update new vignette about programming, docs update May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #5010 (ac1c0c5) into master (7a9eb51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5010   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          75       75           
  Lines       14789    14789           
=======================================
  Hits        14711    14711           
  Misses         78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9eb51...ac1c0c5. Read the comment docs.

@tonyfischetti
Copy link
Contributor

How come it's "Starting from version 1.15.0" and not "Starting from version 1.14.1"?

@jangorecki
Copy link
Member Author

Odd minor version numbers are development version that are not being released to CRAN. In Cran you will find only even minor versions of data.table. So the next CRAN version will be either 1.15.0 or 1.14.2. I bet for 1.15.0.

@tonyfischetti
Copy link
Contributor

Got it! Thanks for clearing that up :)

@mattdowle
Copy link
Member

mattdowle commented May 23, 2021

We typically bump the 2nd number when there's a potential-breaking-changes section. The way current dev is looking, it would be released as 1.14.2. Putting 1.14.2 in the vignette would hedge the bet; i.e. if it is released as 1.14.2 and the vignette said 1.15.0, and we forgot to update the vignette before release, then users might think it wasn't released yet. If it is released as 1.15.0 then it's no problem if the vignette states 1.14.2.

@mattdowle mattdowle changed the title new vignette about programming, docs update programming vignette tweak May 23, 2021
@mattdowle mattdowle merged commit c179b5e into master May 23, 2021
@mattdowle mattdowle deleted the programming-ver branch May 23, 2021 13:58
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants