Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore datatable.nomatch option with warning #5108

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Aug 22, 2021

2 years since #3585 #3612

@mattdowle mattdowle added this to the 1.14.1 milestone Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #5108 (24bd9c8) into master (a87c9b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5108   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          76       76           
  Lines       14612    14612           
=======================================
  Hits        14545    14545           
  Misses         67       67           
Impacted Files Coverage Δ
R/data.table.R 99.94% <ø> (ø)
R/foverlaps.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87c9b0...24bd9c8. Read the comment docs.

@mattdowle mattdowle merged commit 1bc9178 into master Aug 22, 2021
@mattdowle mattdowle deleted the nomatch-global-option branch August 22, 2021 16:42
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants