Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve coverage for gfuns #5192

Merged
merged 5 commits into from
Oct 8, 2021
Merged

improve coverage for gfuns #5192

merged 5 commits into from
Oct 8, 2021

Conversation

ben-schwen
Copy link
Member

Added testcases for increasing coverage of functions that are gforce optimized.

Also added two newlines decreasing coverage to be in line with PR #4299, although I'm not sure if we can really cover those.

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #5192 (d8c5cf3) into master (5f9df4d) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head d8c5cf3 differs from pull request most recent head 230733d. Consider uploading reports for the commit 230733d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5192      +/-   ##
==========================================
+ Coverage   99.38%   99.51%   +0.12%     
==========================================
  Files          77       77              
  Lines       14532    14527       -5     
==========================================
+ Hits        14443    14456      +13     
+ Misses         89       71      -18     
Impacted Files Coverage Δ
src/gsumm.c 100.00% <100.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9df4d...230733d. Read the comment docs.

@MichaelChirico
Copy link
Member

I lean towards reverting the newlines there for now, while we still don't have any good answer to the point raised by Matt here:

#4301 (comment)

@ben-schwen
Copy link
Member Author

I lean towards reverting the newlines there for now, while we still don't have any good answer to the point raised by Matt here:

#4301 (comment)

Perfect for me. I reverted now all newlines for if (nrow != n) to stay consistent.

@mattdowle mattdowle added this to the 1.14.3 milestone Oct 8, 2021
@mattdowle mattdowle merged commit d87150c into master Oct 8, 2021
@mattdowle mattdowle deleted the gforce_coverage branch October 8, 2021 06:02
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants