Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document data.tables with no columns #5615

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Conversation

fkohrt
Copy link
Contributor

@fkohrt fkohrt commented Mar 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #5615 (4d0e66a) into master (8803918) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d0e66a differs from pull request most recent head 2dc8e8f. Consider uploading reports for the commit 2dc8e8f to get more accurate results

@@           Coverage Diff           @@
##           master    #5615   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          80       80           
  Lines       14810    14810           
=======================================
  Hits        14439    14439           
  Misses        371      371           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this matter to be mentioned in FAQ but it is good to elaborate more on why it is like that. What's the difference between 2D matrix and a database table (even if all columns are of the same type).

vignettes/datatable-faq.Rmd Outdated Show resolved Hide resolved
@fkohrt
Copy link
Contributor Author

fkohrt commented Jun 22, 2023

@jangorecki Can you merge this or is something missing?

@jangorecki
Copy link
Member

jangorecki commented Jun 22, 2023

I cannot merge and nothing is missing.
I just don't have write access to master branch.
Just leave it open and it most likely will be merged for next major (non hotfix) release.

@jangorecki jangorecki added this to the 1.14.9 milestone Jun 22, 2023
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
@jangorecki jangorecki modified the milestones: 1.15.0, 1.15.1 Nov 6, 2023
@MichaelChirico
Copy link
Member

LGTM, thanks!

@MichaelChirico MichaelChirico merged commit 8de09b2 into Rdatatable:master Mar 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants