add GOVERNANCE.md document #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 80 80
Lines 14814 14822 +8
=======================================
+ Hits 14439 14447 +8
Misses 375 375 ☔ View full report in Codecov by Sentry. |
jangorecki
reviewed
Nov 28, 2023
jangorecki
reviewed
Nov 28, 2023
jangorecki
reviewed
Nov 28, 2023
jangorecki
reviewed
Nov 28, 2023
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
This comment was marked as outdated.
This comment was marked as outdated.
tdhock
commented
Nov 30, 2023
tdhock
requested review from
lianos,
OfekShilon,
sritchie73,
mattdowle,
renkun-ken,
DavidArenburg,
shrektan,
eliocamp,
TysonStanley,
ben-schwen and
ColeMiller1
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
…into governance
jangorecki
reviewed
Dec 13, 2023
Co-authored-by: Jan Gorecki <J.Gorecki@wit.edu.pl>
|
|
||
| # Roles | ||
|
|
||
| ## Contributor |
There was a problem hiding this comment.
Working on #4278, I wondered if something like "data.table project style guide" is in-scope to discuss here.
There was a problem hiding this comment.
Maybe but if so I would not include any details, instead just link to a wiki page.
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
jangorecki
approved these changes
Dec 14, 2023
|
yay thanks Jan!! |
|
Great work @tdhock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5676
Closes #5722
Closes #5715
Closes #5708
Closes #5714
Hi all! Here is my first draft of a governance document!
I have attempted to incorporate all of the comments/feedback from the issues linked above, but please excuse me if I missed something.
According to the proposed timeline, there is now a month of comments/revisions, and hopefully we can adopt the governance by the end of Dec 2023.