Release changes 1.15

[TysonStanley]

The changes made during the release process to CRAN (minor adjustments and version bump for the tag).

[TysonStanley]

Added version bump to 1.15.99 for merging to master

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f43a96) 97.48% compared to head (3bfe51e) 97.48%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5925   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          80       80           
  Lines       14862    14862           
=======================================
  Hits        14488    14488           
  Misses        374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ben-schwen]

@TysonStanley could you also update the NEWS file to 1.15.0, stating when it was submitted to CRAN and then retag 1.15.0 (at least that's what Matt always did)

[TysonStanley]

Kept the date to match the CRAN version even though that is the initial date and not the resubmission date. In the future releases, will be the resubmission date (where necessary).

[TysonStanley]

Using this branch for the tag. Would recommend merging at least the first two commits here for the master branch when we bring 1.15.99 into master.

[MichaelChirico]

Using this branch for the tag. Would recommend merging at least the first two commits here for the master branch when we bring 1.15.99 into master.

planning to rebase the 1-15-99 branch once this is in master to have the cleanest possible history

[TysonStanley]

Sounds good. The tag is created. Do you want me to create a new PR with just the relevant commits for master?

[ben-schwen]

I guess we are good with this PR

Closes #5931 #5924

[tdhock]

Hi, I don't know if we still care to follow CRAN_Release.cmd, which says the following:

# DO NOT commit or push to GitHub. Leave 4 files (.dev/CRAN_Release.cmd, DESCRIPTION, NEWS and init.c) edited and not committed. Include these in a single and final bump commit below.
# DO NOT even use a PR. Because PRs build binaries and we don't want any binary versions of even release numbers available from anywhere other than CRAN.
# Leave milestone open with a 'release checks' issue open. Keep updating status there.
# ** If on EC2, shutdown instance. Otherwise get charged for potentially many days/weeks idle time with no alerts **
# If it's evening, SLEEP.
# It can take a few days for CRAN's checks to run. If any issues arise, backport locally. Resubmit the same even version to CRAN.
# CRAN's first check is automatic and usually received within an hour. WAIT FOR THAT EMAIL.
# When CRAN's email contains "Pretest results OK pending a manual inspection" (or similar), or if not and it is known why not and ok, then bump dev.

###### Bump dev for NON-PATCH RELEASE
# 0. Close milestone to prevent new issues being tagged with it. The final 'release checks' issue can be left open in a closed milestone.
# 1. Check that 'git status' shows 4 files in modified and uncommitted state: DESCRIPTION, NEWS.md, init.c and this .dev/CRAN_Release.cmd
# 2. Bump minor version in DESCRIPTION to next odd number. Note that DESCRIPTION was in edited and uncommitted state so even number never appears in git.

The last line is what I'm worried about (if we still care to follow these instructions). The "even number never appears in git" means that we should not push any commits with version 1.15.0 to master branch, and instead master should go from 1.14.99 to 1.15.99 -- does that make sense? Also it says below that the specific commit message we should use:

# 8. Push to master with this consistent commit message: "1.14.8 on CRAN. Bump to 1.14.10"

so if you agree, let's close this PR and instead merge #5936 ?

[jangorecki]

The other PR looks better but there are good updates to release procedure here in this PR that make sense to include as well, but probably better not in version bump PR anyway