Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deprecate key="a,b" and by="a,b"" #6049

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Apr 4, 2024

This is a placeholder follow-up to #6047 (which closes #4357). What to do with this PR depends on the outcome of the revdeps checks resulting from #6047. This needs to be decided before 1.16.0 release.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (a11a2e2) to head (cb9ad20).
Report is 8 commits behind head on master.

❗ Current head cb9ad20 differs from pull request most recent head a55ff7c. Consider uploading reports for the commit a55ff7c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6049   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files          80       80           
  Lines       14978    14916   -62     
=======================================
- Hits        14607    14548   -59     
+ Misses        371      368    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdhock
Copy link
Member

tdhock commented Apr 5, 2024

there are 11 revdeps that fail because of #6047
zeitgebr
tidyfst
tidyfast
pointdensityP
maditr
ggPMX
expss
damr
calmr
DramaAnalysis
BTYDplus

@MichaelChirico
Copy link
Member Author

Just filed fix PRs with all the downstreams that host their code on GitHub (all but {pointdensityP}) for which a simple regex search identified some issues. More might remain e.g. in cases like key="a,b,c"; data.table(key = key) which are harder to identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate multiple columns to be defined as scalar character
2 participants