Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate 5 more linters, including return_linter #6128

Merged
merged 9 commits into from May 10, 2024
Merged

Conversation

MichaelChirico
Copy link
Member

Another in the series (prev: #6127).

@tdhock mentioned wanting return_linter() activated, so here it is. Also added missing_argument_linter() which only has one hit.

Copy link

github-actions bot commented May 8, 2024

Comparison Plot

Generated via commit a329059

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 23 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 22 seconds

@MichaelChirico MichaelChirico changed the title missing_argument_linter and return_linter Handle 5 more linters, including return_linter May 9, 2024
@MichaelChirico MichaelChirico changed the title Handle 5 more linters, including return_linter Activate 5 more linters, including return_linter May 9, 2024
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks a lot better thanks

@MichaelChirico MichaelChirico merged commit c8c35f3 into master May 10, 2024
4 checks passed
@MichaelChirico MichaelChirico deleted the lint-apply branch May 10, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants