Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing i18n strings #60

Closed
3 tasks done
BGMP opened this issue Mar 1, 2024 · 2 comments
Closed
3 tasks done

Missing i18n strings #60

BGMP opened this issue Mar 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@BGMP
Copy link
Member

BGMP commented Mar 1, 2024

We'll use this issue to keep track of missing i18n stuff.

  • FAQ: All entries are missing their respective translation keys.
  • Devise: We should regenerate the views using https://github.com/tigrish/devise-i18n for the keys to come in automatically. After doing that, we must then tidy up the views for them to match our current layout.
  • Kaminari: Add missing translation keys.
@BGMP BGMP added the enhancement New feature or request label Mar 1, 2024
@BGMP BGMP changed the title Add missing i18n strings for Devise Missing i18n strings Mar 1, 2024
@BGMP BGMP pinned this issue Mar 1, 2024
@BGMP
Copy link
Member Author

BGMP commented Mar 7, 2024

Although kaminari-i18n already extends support for several locales, it isn't fully compatible with the ones we've defined ourselves; regional locales such as es_cl, es_ar, etc. aren't working out of the box because they need kaminari's keys to be defined in their respective files.

This should just be a matter of copy-pasting these keys into config/locales/en.yml

@BGMP BGMP self-assigned this Mar 7, 2024
@BGMP
Copy link
Member Author

BGMP commented Mar 7, 2024

I'll take care of Kaminari, you keep working on devise @nickskyline

BGMP added a commit that referenced this issue Mar 9, 2024
Progress towards #60
nickskyline pushed a commit that referenced this issue Mar 11, 2024
Progress towards #60
@BGMP BGMP closed this as completed in c32a12d Mar 12, 2024
@BGMP BGMP unpinned this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants