-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for i18n #54
Conversation
nickskyline
commented
Jan 30, 2024
•
edited
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Take a look at the comments I left. We need those resolved before I can review further.
You may request my review when you finish off the changes. Same goes for #53 Thanks, Nick! |
cb62024
to
ba47ee3
Compare
I think this is good enough to merge. The language selector is available at the user settings, it has its own tab. Although, I've been thinking that maybe bringing back the on-screen flag icon to change locales would be a good idea. Could you try the changes out on your end @nickskyline ? |
Looks and works good for me although it's a little weird to me that you have to introduce your password to only change the language. And yes, bringing back that selector is great, specially for unregistered users. @BGMP |
The issue with unregistered users is keeping track of their locale. I'm not sure if rails-i18n supports local storage or a solution similar to that... |
Alright, I've brought back the language selector with the country flags and everything! We should be good to go now! 😄 |