Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FAQ entries #70

Merged
merged 11 commits into from
Mar 16, 2024
Merged

Add missing FAQ entries #70

merged 11 commits into from
Mar 16, 2024

Conversation

nickskyline
Copy link
Member

No description provided.

@nickskyline nickskyline requested a review from BGMP as a code owner March 14, 2024 20:20
Copy link
Member

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @nickskyline . Check out my comments and re-request the review when you get to them.

app/assets/stylesheets/faq.scss Outdated Show resolved Hide resolved
app/views/faq/index.haml Outdated Show resolved Hide resolved
app/assets/images/faq/shortcut.png Outdated Show resolved Hide resolved
@nickskyline nickskyline requested a review from BGMP March 15, 2024 15:01
Copy link
Member

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the duplicate #faq ID, and also made it so that all entries can remain open even if the user opens another one. Other than that this looks good to go!

@BGMP BGMP merged commit 40e5777 into master Mar 16, 2024
3 checks passed
@BGMP BGMP mentioned this pull request Mar 16, 2024
2 tasks
@nickskyline nickskyline deleted the dev-nick-2 branch May 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants