-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translation keys #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must also translate these:
RVA/app/controllers/stats_controller.rb
Lines 13 to 18 in 769814c
:race_wins => 'Wins', | |
:race_podiums => 'Podiums', | |
:race_win_rate => 'Win Ratio', | |
# average_position: 'Average Position', | |
:obtained_points => 'Obtained Points', | |
:official_score => 'Official Score' |
You can use I18n.t("path.to.key")
directly within the controller, so it should be easy enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes! I left a few comments and suggestions. After you check those out, we should be good to go with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.