Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation keys #76

Merged
merged 30 commits into from
Mar 21, 2024
Merged

Add missing translation keys #76

merged 30 commits into from
Mar 21, 2024

Conversation

nickskyline
Copy link
Member

No description provided.

@nickskyline nickskyline requested a review from BGMP as a code owner March 19, 2024 15:56
Copy link
Member

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must also translate these:

:race_wins => 'Wins',
:race_podiums => 'Podiums',
:race_win_rate => 'Win Ratio',
# average_position: 'Average Position',
:obtained_points => 'Obtained Points',
:official_score => 'Official Score'

You can use I18n.t("path.to.key") directly within the controller, so it should be easy enough.

@nickskyline nickskyline requested a review from BGMP March 20, 2024 15:37
Copy link
Member

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes! I left a few comments and suggestions. After you check those out, we should be good to go with this.

app/controllers/teams_controller.rb Outdated Show resolved Hide resolved
app/controllers/users_controller.rb Outdated Show resolved Hide resolved
app/views/cars/edit.haml Outdated Show resolved Hide resolved
app/views/cars/show.haml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@nickskyline nickskyline requested a review from BGMP March 21, 2024 15:03
Copy link
Member

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BGMP BGMP merged commit 5296c9f into master Mar 21, 2024
3 checks passed
Copy link

sentry-io bot commented Mar 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ I18n::InvalidLocale: "Português, Brasil" is not a valid locale (I18n::InvalidLocale) UsersController#update_locale View Issue

Did you find this useful? React with a 👍 or 👎

@nickskyline nickskyline deleted the dev-nick branch May 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants