Sweeping skeletons #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
previously approved these changes
Oct 9, 2020
| helpers::curl_post(ss.str(), config_.port, params, config_.username, config_.password); | ||
| } catch (helpers::curl_exception &exception) { | ||
| logger_->critical("curl failed: {}", exception.what()); | ||
| std::size_t retries = 10; // we come by this value using digital suction |
There was a problem hiding this comment.
If this fails for any other reason than the API being unreachable, it will block all queued status notifications (that could otherwise proceed without delay). I'm not sure if that's a problem.
krulis-martin
force-pushed
the
sweeping-skeletons
branch
from
83ea20e
to
7ae457a
Compare
krulis-martin
force-pushed
the
sweeping-skeletons
branch
from
7ae457a
to
067964a
Compare
SemaiCZE
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... out of the drawers.