Making sure group names container loads also archived groups.

ReCodEx · Oct 3, 2021 · 6290338 · 6290338
1 parent 72732cc
commit 6290338
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/containers/GroupsNameContainer/GroupsNameContainer.js b/src/containers/GroupsNameContainer/GroupsNameContainer.js
@@ -108,6 +108,9 @@ export default connect(
     groupAccessor: groupAccessorSelector(state),
   }),
   dispatch => ({
-    loadAsync: groupId => dispatch(fetchGroupIfNeeded(groupId)),
+    loadAsync: groupId =>
+      dispatch(fetchGroupIfNeeded(groupId)).then(({ value: group }) =>
+        Promise.all(group && group.archived ? group.parentGroupsIds.map(id => dispatch(fetchGroupIfNeeded(id))) : [])
+      ),
   })
 )(GroupsNameContainer);
diff --git a/src/pages/GroupInfo/GroupInfo.js b/src/pages/GroupInfo/GroupInfo.js
@@ -55,7 +55,6 @@ class GroupInfo extends Component {
           dispatch(fetchByIds(safeGet(group, ['primaryAdminsIds'], []))),
           dispatch(fetchByIds(safeGet(group, ['privateData', 'supervisors'], []))),
           dispatch(fetchByIds(safeGet(group, ['privateData', 'observers'], []))),
-          group.archived ? dispatch(fetchAllGroups({ archived: true })) : null,
         ])
       );
 

diff --git a/src/pages/GroupUserSolutions/GroupUserSolutions.js b/src/pages/GroupUserSolutions/GroupUserSolutions.js
@@ -253,12 +253,11 @@ class GroupUserSolutions extends Component {
     Promise.all([
       dispatch(fetchUserIfNeeded(userId)),
       dispatch(fetchGroupIfNeeded(groupId)).then(({ value: group }) =>
-        hasPermissions(group, 'viewAssignments')
-          ? Promise.all([
-              dispatch(fetchAssignmentsForGroup(groupId)),
-              dispatch(fetchGroupStudentsSolutions(groupId, userId)),
-            ])
-          : Promise.resolve()
+        Promise.all(
+          hasPermissions(group, 'viewAssignments')
+            ? [dispatch(fetchAssignmentsForGroup(groupId)), dispatch(fetchGroupStudentsSolutions(groupId, userId))]
+            : []
+        )
       ),
       dispatch(fetchRuntimeEnvironments()),
     ]);