Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission is counted when file upload dialog fails #153

Closed
Sejsel opened this issue Dec 19, 2017 · 1 comment
Closed

Submission is counted when file upload dialog fails #153

Sejsel opened this issue Dec 19, 2017 · 1 comment
Assignees

Comments

@Sejsel
Copy link
Contributor

Sejsel commented Dec 19, 2017

When the file upload dialog fails with an error that triggers the app.submistSolution.submitFailed (sic) message, the submission is still counted.

The submission is in the following state afterwards:

Evaluation Status: Solution was not submitted for evaluation. This was probably caused by an error in the assignment configuration

Since the very same files worked on another attempt, this doesn't seem to be an error in the assignment.

@Neloop
Copy link
Member

Neloop commented Dec 19, 2017

Hello,
thanks for the feedback. There seems to be inconsistency between counting valid submissions in web-app and api. Web-app is performing its own counting which is inaccurate. Please note that this is only displaying issue. Api will still accept submissions even if submission count in web-app will be higher then threshold (Of course till the actual threshold which is computed correctly in api).
We will look at this and send proper count from api to web-app which then only displays it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants