Automatically logout after token expires #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemaiCZE
approved these changes
Oct 18, 2017
Neloop
previously requested changes
Oct 18, 2017
There was a problem hiding this comment.
Wrong credentials return 401 from api. This leads to wrong notification "Invalid token".
Maybe change here: https://github.com/ReCodEx/api/blob/master/app/exceptions/WrongCredentialsException.php#L17 will be needed
simonrozsival
dismissed
Neloop’s stale review
After discussion we decided to change the API to return 400 instead of 401 for the login request.
Neloop
approved these changes
Oct 22, 2017
|
Fixes #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.