String sorting comparators fixed to use selected locale. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemaiCZE
reviewed
Oct 21, 2017
| @@ -94,7 +95,8 @@ AttachedFilesTable.propTypes = { | |||
| newFiles: ImmutablePropTypes.list, | |||
| addFiles: PropTypes.func, | |||
| HeaderComponent: PropTypes.func.isRequired, | |||
| RowComponent: PropTypes.func.isRequired | |||
| RowComponent: PropTypes.func.isRequired, | |||
| intl: PropTypes.shape({ formatMessage: PropTypes.func.isRequired }).isRequired | |||
There was a problem hiding this comment.
I think you don't use function intl.formatMessage() here, so there is no need to check its existence in prop types. Instead, you use a intl.locale, so you can check this in here. I'm not sure about the type, but I think it is a string. To sum up, you probably wanted something like
intl: PropTypes.shape({ locale: PropTypes.string.isRequired }).isRequired
added 2 commits
October 22, 2017 23:18
SemaiCZE
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.