Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): refactor Editor_ConvertSpawns function #80

Merged
merged 1 commit into from Jan 23, 2024

Conversation

wopox1337
Copy link
Collaborator

fix #79

Refactored the Editor_ConvertSpawns function to improve code readability and maintainability. Modified the function to return the count of successfully converted spawns instead of a boolean value. Introduced conditional checks and log messages to handle edge cases, such as when no valid spawn files are found or when an invalid argument count is encountered. Updated the commit message to reflect these changes.

Refactored the `Editor_ConvertSpawns` function to improve code readability and maintainability. Renamed the function from `static bool: Editor_ConvertSpawns()` to `static ConvertOldSpawnsFile(const file[])`. Modified the function to return the count of successfully converted spawns instead of a boolean value. Introduced conditional checks and log messages to handle edge cases, such as when no valid spawn files are found or when an invalid argument count is encountered. Updated the commit message to reflect these changes.
@wopox1337 wopox1337 self-assigned this Jan 23, 2024
@wopox1337 wopox1337 added enhancement New feature or request good first issue Good for newcomers labels Jan 23, 2024
@wopox1337 wopox1337 added this to the 1.0.0 milestone Jan 23, 2024
@wopox1337 wopox1337 merged commit 49c5852 into master Jan 23, 2024
2 checks passed
@wopox1337 wopox1337 deleted the fix/spawns_convert_logging branch January 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better logging for redm_convert_spawns
1 participant