create_re: sigmas must be positive #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 95.76% 95.79% +0.03%
==========================================
Files 4 4
Lines 118 119 +1
==========================================
+ Hits 113 114 +1
Misses 5 5 ☔ View full report in Codecov by Sentry. |
palday
reviewed
Feb 4, 2022
src/utilities.jl
Outdated
| @@ -281,6 +281,7 @@ random effects. | |||
| [`update!`](@ref) requires. | |||
| """ | |||
| function create_re(sigmas...; corrmat=nothing) | |||
| @assert all(>(0),sigmas) "all σs must be positive" | |||
There was a problem hiding this comment.
@assertcan be optimized out in certain cases, so there's no guarantee that this will execute- On the mixed model side, the restriction is that sigma is greater than or equal to zero (if you're simulating singular fits).
- I have very mixed feelings about this level of hand holding. While this is certainly an assumption of the code (and should probably be mentioned in the docstring), a user that knowlingly passes a negative variance for simulation can't be trusted with simulation at all. 😉 If it's about catching sigmas that were programmatically generated elsewhere and there was a bug in that elsewhere, then elsewhere should be responsible for its own bug.
palday
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.