Merge pull request openjournals#1279 from openjournals/editor-status

Adding editor status to JSON response

app/models/editor.rb

@@ -36,6 +36,14 @@ def category_list
     categories.join(", ")
   end
 
+  def status
+    if retired?
+      "Retired"
+    else
+      "Active"
+    end
+  end
+
   def three_month_average
     paper_count = self.papers.visible.since(3.months.ago).count
     return sprintf("%.1f", paper_count / 3.0)

app/views/papers/show.json.jbuilder

@@ -12,6 +12,7 @@ if @paper.published?
   json.authors @paper.metadata_authors
   json.submitting_author @paper&.submitting_author&.pretty_github_username
   json.editor @paper.metadata_editor
+  json.editor_status @paper&.editor&.status
   if @paper.editor
     json.editor_name @paper.editor.full_name
     json.editor_url @paper.editor.url if @paper.editor.url

spec/controllers/papers_controller_spec.rb

@@ -404,6 +404,7 @@
       expect(parsed_response["state"]).to eq("accepted")
       expect(parsed_response["software_repository"]).to eq("http://github.com/arfon/fidgit")
       expect(parsed_response["editor"]).to eq("@arfon")
+      expect(parsed_response["editor_status"]).to eq("Active")
       expect(parsed_response["submitting_author"]).to eq("@foobar")
       expect(parsed_response["editor_name"]).to eq("Person McEditor")
       expect(parsed_response["editor_orcid"]).to eq("0000-0000-0000-1234")