Provide more information on Routable fatalErrors #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 80.28% 81.05% +0.76%
==========================================
Files 5 5
Lines 208 227 +19
==========================================
+ Hits 167 184 +17
- Misses 41 43 +2
Continue to review full report at Codecov.
|
mjarvis
approved these changes
Oct 11, 2017
DivineDominion
approved these changes
Oct 12, 2017
The default implementation for the function to push, pon, and change provided via protocol extension fatalErrors to notify developers that they haven't provided the required implementation. The message used in the fatalError was not informative enough. These changes make it granular to the actual function being used, as well as adding the type that caused the failure, and the route element parameters that the code was trying to act on. The new error message for push for example will look something like: ``` This routable cannot push segments. You have not implemented it. (Asked RootRoutable to push landing) ```
mokagio
force-pushed
the
mokagio/fix-fatal-error-messages
branch
from
a8045eb
to
611d9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation for the function to push, pop, and change provided via protocol extension fatalErrors to notify developers that they haven't provided the required implementation.
The message used in the fatalError was not informative enough. These changes make it granular to the actual function being used, as well as adding the type that caused the failure, and the route element parameters that the code was trying to act on.
The new error message for push for example will look something like: