Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest version of Quick/Nimble #95

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Use latest version of Quick/Nimble #95

merged 1 commit into from
Oct 5, 2018

Conversation

hlineholm
Copy link
Contributor

Duplicated by #81

@hlineholm hlineholm added the bug label Aug 2, 2018
@hlineholm hlineholm requested a review from mjarvis August 2, 2018 21:47
@hlineholm hlineholm removed the bug label Aug 2, 2018
@hlineholm hlineholm mentioned this pull request Aug 2, 2018
Closed
mjarvis
mjarvis requested changes Aug 2, 2018
View reviewed changes
Copy link
Member

@mjarvis mjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you'll need to run carthage update in order to update the resolved file, which will make bootstrap install the correct versions.

@mjarvis mjarvis mentioned this pull request Aug 2, 2018
Closed
@hlineholm hlineholm force-pushed the hlineholm/update-quick-nimble-to-latest-version branch from 2e453dc to ecbbf6d Compare October 4, 2018 21:19
@hlineholm
Copy link
Contributor Author

@mjarvis the cart file is resolved.

@DivineDominion
Copy link
Contributor

Needed this for local testing, too, and it worked, so LGTM

@DivineDominion DivineDominion merged commit 0e8129c into ReSwift:master Oct 5, 2018
@ghost ghost deleted the hlineholm/update-quick-nimble-to-latest-version branch October 9, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjarvis mjarvis mjarvis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hlineholm @DivineDominion @mjarvis