Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with info about how to create a combined subscription #401

Merged
merged 1 commit into from Jul 3, 2019

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Mar 29, 2019

As per @DivineDominion's request here, I've added a subsection with a brief explanation of how to create a subscription combining several substates easily.

@DivineDominion
Copy link
Contributor

Looking at the README now, I think a couple more lines of code would be useful: what's the AppState like, and how does the MySubState assemble a view into it?

Then it might be a better fit for the guides instead of the front page README. What do you think?

@DivineDominion
Copy link
Contributor

@danielmartinprieto What do you say about the suggestions? Do you think it makes sense to move this from the README to the guides/help files, too?

@dani-mp
Copy link
Contributor Author

dani-mp commented Jun 16, 2019

Sorry, I didn't have time to do this. Yeah, it's totally fine, we can later link some FAQs from the README to those guides.

@dani-mp
Copy link
Contributor Author

dani-mp commented Jun 16, 2019

You can move it already if you want, and we'll improve it later. Better having something (even if it's not complete) that nothing at all.

@DivineDominion DivineDominion merged commit b5b1fcc into master Jul 3, 2019
@DivineDominion
Copy link
Contributor

You're right, doesn't do any harm for now.

@DivineDominion DivineDominion deleted the danielmartinprieto-patch-1 branch November 30, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants