Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering not advertising to Xiaomi users to download the HW version #50

Closed
trmdi opened this issue Apr 5, 2024 · 7 comments
Closed

Comments

@trmdi
Copy link

trmdi commented Apr 5, 2024

Unlike Huawei phones, not all Xiaomi ones are uncertified from Google, they can login without having to apply specific Huawei setting. While applying that setting could have some unforeseen consequences like microG says:

Screenshot_2024-04-05-11-51-41-316-edit_app revanced android gms

So in the release page, we should only suggest Xiaomi phones(and maybe other ones running custom rom?) to try the -hw version only if login fails, but should not advertise Xiaomi users to always use that file.

Screenshot_2024-04-05-11-57-29-052-edit_com sec android app sbrowser

@oSumAtrIX
Copy link
Member

Until any issues arise with the HW release for Xiaomi users, we should not delegate the choice to users who don't know better. The change was done out of necessity to close #37.

If there's anything else, let me know.

@oSumAtrIX
Copy link
Member

If this setting needs to be off for uncertified devices, is it necessary to toggle the setting off for any custom ROM?

@cyberboh
Copy link

cyberboh commented Apr 5, 2024

Xiaomi running on MIUI/HyperOS, Worst and Broken OS in this world. They shipped their devices with many version of Rom's, e.g Global rom, China rom, Russia Rom, Vietnam Rom, Turkiye Rom, etc etc.
In every Rom, it has slightly differences, also need different treatments. Especially China Rom which is Google (Gms Services) not available inside.

My humble request is, just make Xiaomi (MIUI/HyperOS) same like other phone (Suggest General GmsCore). Else if it's not work, let them to use Huawei GmsCore. Also suggest general GmsCore for custom roms based on AOSP (Most xiaomi devices custom-rom ready).

Maybe add ReVanced Announcement about this issue.

@oSumAtrIX
Copy link
Member

I am asking about custom roms in general, do they count as uncertified and would they need the Huawei version?

@cyberboh
Copy link

cyberboh commented Apr 5, 2024

I am asking about custom roms in general, do they count as uncertified and would they need the Huawei version?

There 2 big custom rom based on availability of Gapps.

  1. Gappsless or built in with MicroG
  2. Shipped with gapps

For Gappsless they needs -hw version. Else it needs original.

For notes: LineageOS official not only Gappsless but also safetynet won't passed out of the box. Idk original GmsCore would work or not.

@oSumAtrIX
Copy link
Member

I have tested on a Gappsless emulator and the hw version was not necessary.

@cyberboh
Copy link

cyberboh commented Apr 5, 2024

I have tested on a Gappsless emulator and the hw version was not necessary.

But Huawei is not gapps rom, and it needs special treatments to using -hw variant.
I think emulators and Huawei devices are slightly different even they are is not gapps shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants