feat(YouTube - Hide layout components): Filter home/search results by keywords #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
8f5de43
to
1b83167
Compare
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
1b83167
to
19e7810
Compare
oSumAtrIX
requested changes
Mar 9, 2024
app/src/main/java/app/revanced/integrations/youtube/TrieSearch.java
Outdated
Show resolved
Hide resolved
...main/java/app/revanced/integrations/youtube/patches/components/HideKeywordContentFilter.java
Outdated
Show resolved
Hide resolved
...main/java/app/revanced/integrations/youtube/patches/components/HideKeywordContentFilter.java
Outdated
Show resolved
Hide resolved
...main/java/app/revanced/integrations/youtube/patches/components/HideKeywordContentFilter.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…s-is for the user to fix.
…Use code points for better compatibility with some foreign languages.
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
89b9637
to
80f12f7
Compare
oSumAtrIX
reviewed
Mar 11, 2024
...src/main/java/app/revanced/integrations/youtube/patches/components/KeywordContentFilter.java
Show resolved
Hide resolved
...main/java/app/revanced/integrations/youtube/patches/components/HideKeywordContentFilter.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Mar 11, 2024
...src/main/java/app/revanced/integrations/youtube/patches/components/KeywordContentFilter.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Mar 11, 2024
...src/main/java/app/revanced/integrations/youtube/patches/components/KeywordContentFilter.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Mar 11, 2024
| "home_video_with_content.eml", | ||
| "search_video_with_context.eml", | ||
| "related_video_with_content", | ||
| "compact_video.eml", |
There was a problem hiding this comment.
grid_video_wrapper.em appears in channels which features a list of videos. The filter can be used to block keywords in the title:
There was a problem hiding this comment.
Do users want to hide videos for a channel they intentionally navigated to?
Maybe for now leave that one for custom filter, just to keep this feature specifically for hiding home/feed.
There was a problem hiding this comment.
Do users want to hide videos for a channel they intentionally navigated to?
In some scenarios, this can be useful. For example, they talk about many subjects if you want to filter for profanity or a specific topic, such as in the LinusTechTips channel.
In other scenarios, that may not be wanted, such as when you want to filter a specific channel entirely, such as Mr Beast, but occasionally want to manually check their channel.
That could be solved by allowing the user to choose the filters via an additional input preference. Alternatively, a couple of switches, such as a "Filter channel videos" switch, could be added for such cases.
oSumAtrIX
reviewed
Mar 11, 2024
...src/main/java/app/revanced/integrations/youtube/patches/components/KeywordContentFilter.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Mar 11, 2024
| "search_video_with_context.eml", | ||
| "related_video_with_content", | ||
| "compact_video.eml", | ||
| "inline_shorts", |
There was a problem hiding this comment.
compact_playlist.eml seems to be present under a channels "Playlist" tab. I think it could also appear under other feeds:
There was a problem hiding this comment.
Compact_playlist, or compact_video?
Compact_video is to filter shorts in tablet layout.
There was a problem hiding this comment.
compact_playlist are the playlist components visible in the screenshot I attached:
There was a problem hiding this comment.
If there is a way to distinguish if a playlist is in the feed/search and not a channel playlist, then it can be included for this PR.
But if there is no easy way to distinguish, then I think it should not hide because hiding channel page content should be opt-in only. It can be an extra UI switch if selective filtering options are figured out.
There was a problem hiding this comment.
There are "Mix" playlists in feeds, but I am not sure if those are the same components. Unfortunately, I can not get them to appear on my feeds, but I can imagine that "compact_playlist" could appear in the feeds, just like "compact_video"
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
3fdff39
to
463536f
Compare
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
996590b
to
27ba80e
Compare
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
3224412
to
3f676c3
Compare
# Conflicts: # app/src/main/java/app/revanced/integrations/youtube/patches/components/LithoFilterPatch.java
oSumAtrIX
reviewed
Mar 26, 2024
LisoUseInAIKyrios
force-pushed
the
filter_keyword_content
branch
from
6e93e2a
to
89e0495
Compare
oSumAtrIX
approved these changes
Mar 27, 2024
revanced-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [1.5.0-dev.9](v1.5.0-dev.8...v1.5.0-dev.9) (2024-03-27) ### Bug Fixes * Check index of pattern in string instead of the other way around ([e3ba343](e3ba343)) * **YouTube - Hide layout components:** Correctly hide Join button ([b945e2f](b945e2f)) * **YouTube - Hide Shorts components:** Correctly hide join button ([b7a8995](b7a8995)) * **YouTube:** Fix video playback by switching to ReVanced GmsCore vendor ([#589](#589)) ([3a34a23](3a34a23)) ### Features * **YouTube - Hide layout components:** Filter home/search results by keywords ([#584](#584)) ([0222a4a](0222a4a)) * **YouTube - Hide Shorts components:** Hide like and dislike buttons ([2a08e5a](2a08e5a)) * **YouTube - Hide Shorts components:** Hide sound metadata label ([46d8ef6](46d8ef6)) * **YouTube - Hide Shorts components:** Hide title and full video link label ([59165de](59165de))
oSumAtrIX
added a commit
that referenced
this pull request
Mar 27, 2024
… keywords (#584) Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
revanced-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [1.5.0-dev.9](v1.5.0-dev.8...v1.5.0-dev.9) (2024-03-27) ### Bug Fixes * Check index of pattern in string instead of the other way around ([96a1e46](96a1e46)) * **YouTube - Hide layout components:** Correctly hide Join button ([b945e2f](b945e2f)) * **YouTube - Hide Shorts components:** Correctly hide join button ([b7a8995](b7a8995)) * **YouTube:** Fix video playback by switching to ReVanced GmsCore vendor ([#589](#589)) ([6e947e2](6e947e2)) ### Features * **YouTube - Hide layout components:** Filter home/search results by keywords ([#584](#584)) ([0cbad98](0cbad98)) * **YouTube - Hide Shorts components:** Hide like and dislike buttons ([2a08e5a](2a08e5a)) * **YouTube - Hide Shorts components:** Hide sound metadata label ([46d8ef6](46d8ef6)) * **YouTube - Hide Shorts components:** Hide title and full video link label ([59165de](59165de))
revanced-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [1.5.0](v1.4.0...v1.5.0) (2024-03-27) ### Bug Fixes * Check index of pattern in string instead of the other way around ([96a1e46](96a1e46)) * Handle custom preferences ([#586](#586)) ([ad477e4](ad477e4)) * Revert AGP dependency update ([ab07a56](ab07a56)) * **TikTok:** Hook application context earlier to prevent crash ([#588](#588)) ([9ac2d63](9ac2d63)) * **YouTube - Announcements:** Only compare ID to not show same announcement after a fix-up ([#579](#579)) ([5d14f53](5d14f53)) * **YouTube - Client spoof:** Allow playback for links with timestamp ([#582](#582)) ([eee3f35](eee3f35)) * **YouTube - Disable suggested video end screen:** Disable by default to fix autoplay issues ([#578](#578)) ([b9c1eec](b9c1eec)) * **YouTube - Downloads:** Use new task context ([#583](#583)) ([468dfac](468dfac)) * **YouTube - HDR auto brightness:** Remove non functional and obsolete patch ([#585](#585)) ([b060732](b060732)) * **YouTube - Hide ads:** Prevent app crash if hiding fullscreen ads is not possible ([#590](#590)) ([4ec955f](4ec955f)) * **YouTube - Hide layout components:** Correctly hide Join button ([b945e2f](b945e2f)) * **YouTube - Hide seekbar:** Use original seekbar color if Theme patch is not included ([#580](#580)) ([8d48a90](8d48a90)) * **YouTube - Hide Shorts components:** Correctly hide join button ([b7a8995](b7a8995)) * **YouTube:** Fix video playback by switching to ReVanced GmsCore vendor ([#589](#589)) ([6e947e2](6e947e2)) ### Features * **YouTube - Downloads:** Use external downloader when selecting 'Download' in home feed flyout menu ([#587](#587)) ([254da31](254da31)) * **YouTube - External downloader:** Add ability to use in-app download button ([771a0de](771a0de)) * **YouTube - Hide layout components:** Filter home/search results by keywords ([#584](#584)) ([0cbad98](0cbad98)) * **YouTube - Hide Shorts components:** Hide like and dislike buttons ([2a08e5a](2a08e5a)) * **YouTube - Hide Shorts components:** Hide sound metadata label ([46d8ef6](46d8ef6)) * **YouTube - Hide Shorts components:** Hide title and full video link label ([59165de](59165de)) * **YouTube - Hide Shorts components:** Selectively hide Shorts for home / subscription / search ([#592](#592)) ([1ee99aa](1ee99aa))
E85Addict
pushed a commit
to E85Addict/revanced-integrations
that referenced
this pull request
Mar 27, 2024
# [1.4.0](v1.3.2...v1.4.0) (2024-03-27) ### Bug Fixes * Check index of pattern in string instead of the other way around ([96a1e46](96a1e46)) * Handle custom preferences ([ReVanced#586](https://github.com/E85Addict/revanced-integrations/issues/586)) ([ad477e4](ad477e4)) * Revert AGP dependency update ([ab07a56](ab07a56)) * **TikTok:** Hook application context earlier to prevent crash ([ReVanced#588](https://github.com/E85Addict/revanced-integrations/issues/588)) ([9ac2d63](9ac2d63)) * **Twitter - Hide ads:** Hide ads in search ([b40687c](b40687c)) * **YouTube - Announcements:** Only compare ID to not show same announcement after a fix-up ([ReVanced#579](https://github.com/E85Addict/revanced-integrations/issues/579)) ([5d14f53](5d14f53)) * **YouTube - Client spoof:** Allow playback for links with timestamp ([ReVanced#582](https://github.com/E85Addict/revanced-integrations/issues/582)) ([eee3f35](eee3f35)) * **YouTube - Disable suggested end screen:** Reliably hide end screen ([b4ab5f6](b4ab5f6)) * **YouTube - Disable suggested video end screen:** Disable by default to fix autoplay issues ([ReVanced#578](https://github.com/E85Addict/revanced-integrations/issues/578)) ([b9c1eec](b9c1eec)) * **YouTube - Downloads:** Use new task context ([ReVanced#583](https://github.com/E85Addict/revanced-integrations/issues/583)) ([468dfac](468dfac)) * **YouTube - HDR auto brightness:** Remove non functional and obsolete patch ([ReVanced#585](https://github.com/E85Addict/revanced-integrations/issues/585)) ([b060732](b060732)) * **YouTube - Hide ads:** Do not show error toast and hide full screen ads ([ReVanced#569](https://github.com/E85Addict/revanced-integrations/issues/569)) ([0b0d46f](0b0d46f)) * **YouTube - Hide ads:** Prevent app crash if hiding fullscreen ads is not possible ([ReVanced#590](https://github.com/E85Addict/revanced-integrations/issues/590)) ([4ec955f](4ec955f)) * **YouTube - Hide layout components:** Correctly hide Join button ([b945e2f](b945e2f)) * **YouTube - Hide seekbar:** Use original seekbar color if Theme patch is not included ([ReVanced#580](https://github.com/E85Addict/revanced-integrations/issues/580)) ([8d48a90](8d48a90)) * **YouTube - Hide Shorts components:** Correctly hide join button ([b7a8995](b7a8995)) * **YouTube - Hide Shorts:** Hide Shorts in feed when using tablet layout ([ReVanced#572](https://github.com/E85Addict/revanced-integrations/issues/572)) ([7f5e7df](7f5e7df)) * **YouTube - Spoof app version:** Remove broken versions ([ReVanced#573](https://github.com/E85Addict/revanced-integrations/issues/573)) ([fb4aab7](fb4aab7)) * **YouTube:** Fix video playback by switching to ReVanced GmsCore vendor ([ReVanced#589](https://github.com/E85Addict/revanced-integrations/issues/589)) ([6e947e2](6e947e2)) ### Features * **Sync for Reddit:** Add `Fix /s/ links` patch ([a8c82ad](a8c82ad)) * **X:** Add `Open links as query` patch ([ReVanced#570](https://github.com/E85Addict/revanced-integrations/issues/570)) ([95ca632](95ca632)) * **YouTube - Change start page:** Add more start pages ([27421fb](27421fb)) * **YouTube - Downloads:** Use external downloader when selecting 'Download' in home feed flyout menu ([ReVanced#587](https://github.com/E85Addict/revanced-integrations/issues/587)) ([254da31](254da31)) * **YouTube - External downloader:** Add ability to use in-app download button ([771a0de](771a0de)) * **YouTube - Hide layout components:** Filter home/search results by keywords ([ReVanced#584](https://github.com/E85Addict/revanced-integrations/issues/584)) ([0cbad98](0cbad98)) * **YouTube - Hide Shorts components:** Hide like and dislike buttons ([2a08e5a](2a08e5a)) * **YouTube - Hide Shorts components:** Hide sound metadata label ([46d8ef6](46d8ef6)) * **YouTube - Hide Shorts components:** Hide title and full video link label ([59165de](59165de)) * **YouTube - Hide Shorts components:** Selectively hide Shorts for home / subscription / search ([ReVanced#592](https://github.com/E85Addict/revanced-integrations/issues/592)) ([1ee99aa](1ee99aa)) * **YouTube - Spoof app version:** Add target versions ([ReVanced#574](https://github.com/E85Addict/revanced-integrations/issues/574)) ([da57fb9](da57fb9)) * **YouTube:** Reorganize settings menu ([ReVanced#571](https://github.com/E85Addict/revanced-integrations/issues/571)) ([eea4a48](eea4a48)) ### Performance Improvements * Add upstream sync ([639670f](639670f))
E85Addict
pushed a commit
to E85Addict/revanced-integrations
that referenced
this pull request
Mar 27, 2024
# [1.5.0](v1.4.0...v1.5.0) (2024-03-27) ### Bug Fixes * Check index of pattern in string instead of the other way around ([96a1e46](96a1e46)) * Handle custom preferences ([ReVanced#586](https://github.com/E85Addict/revanced-integrations/issues/586)) ([ad477e4](ad477e4)) * Revert AGP dependency update ([ab07a56](ab07a56)) * **TikTok:** Hook application context earlier to prevent crash ([ReVanced#588](https://github.com/E85Addict/revanced-integrations/issues/588)) ([9ac2d63](9ac2d63)) * **YouTube - Announcements:** Only compare ID to not show same announcement after a fix-up ([ReVanced#579](https://github.com/E85Addict/revanced-integrations/issues/579)) ([5d14f53](5d14f53)) * **YouTube - Client spoof:** Allow playback for links with timestamp ([ReVanced#582](https://github.com/E85Addict/revanced-integrations/issues/582)) ([eee3f35](eee3f35)) * **YouTube - Disable suggested video end screen:** Disable by default to fix autoplay issues ([ReVanced#578](https://github.com/E85Addict/revanced-integrations/issues/578)) ([b9c1eec](b9c1eec)) * **YouTube - Downloads:** Use new task context ([ReVanced#583](https://github.com/E85Addict/revanced-integrations/issues/583)) ([468dfac](468dfac)) * **YouTube - HDR auto brightness:** Remove non functional and obsolete patch ([ReVanced#585](https://github.com/E85Addict/revanced-integrations/issues/585)) ([b060732](b060732)) * **YouTube - Hide ads:** Prevent app crash if hiding fullscreen ads is not possible ([ReVanced#590](https://github.com/E85Addict/revanced-integrations/issues/590)) ([4ec955f](4ec955f)) * **YouTube - Hide layout components:** Correctly hide Join button ([b945e2f](b945e2f)) * **YouTube - Hide seekbar:** Use original seekbar color if Theme patch is not included ([ReVanced#580](https://github.com/E85Addict/revanced-integrations/issues/580)) ([8d48a90](8d48a90)) * **YouTube - Hide Shorts components:** Correctly hide join button ([b7a8995](b7a8995)) * **YouTube:** Fix video playback by switching to ReVanced GmsCore vendor ([ReVanced#589](https://github.com/E85Addict/revanced-integrations/issues/589)) ([6e947e2](6e947e2)) ### Features * **YouTube - Downloads:** Use external downloader when selecting 'Download' in home feed flyout menu ([ReVanced#587](https://github.com/E85Addict/revanced-integrations/issues/587)) ([254da31](254da31)) * **YouTube - External downloader:** Add ability to use in-app download button ([771a0de](771a0de)) * **YouTube - Hide layout components:** Filter home/search results by keywords ([ReVanced#584](https://github.com/E85Addict/revanced-integrations/issues/584)) ([0cbad98](0cbad98)) * **YouTube - Hide Shorts components:** Hide like and dislike buttons ([2a08e5a](2a08e5a)) * **YouTube - Hide Shorts components:** Hide sound metadata label ([46d8ef6](46d8ef6)) * **YouTube - Hide Shorts components:** Hide title and full video link label ([59165de](59165de)) * **YouTube - Hide Shorts components:** Selectively hide Shorts for home / subscription / search ([ReVanced#592](https://github.com/E85Addict/revanced-integrations/issues/592)) ([1ee99aa](1ee99aa)) ### Performance Improvements * Add upstream sync ([639670f](639670f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration changes for ReVanced/revanced-patches#2853