Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube - Navigation buttons): Add option to hide navigation button labels #635

Merged
merged 2 commits into from
May 18, 2024
Merged

feat(YouTube - Navigation buttons): Add option to hide navigation button labels #635

merged 2 commits into from
May 18, 2024

Conversation

MarcaDian
Copy link
Contributor

@MarcaDian MarcaDian mentioned this pull request May 18, 2024
Merged
@LisoUseInAIKyrios
Copy link
Contributor

It might be possible to do this without any additional fingerprints.

The button layout container is passed in on creation (for hiding the nav button), but the textview could probably be found using Utils.getChildView() with an instanceof check for the text view.

@oSumAtrIX oSumAtrIX changed the title feat(YouTube): Hide navigation button labels feat(YouTube - Navigation buttons): Add option to hide navigation button labels May 18, 2024
@oSumAtrIX
Copy link
Member

I think solving with a patch time rather than a runtime solution is simpler and more consistent.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 6bd0ac2 into ReVanced:dev May 18, 2024
2 checks passed
@MarcaDian MarcaDian deleted the hide_nav_labels branch May 18, 2024 21:15
revanced-bot pushed a commit that referenced this pull request May 18, 2024
@semantic-release-bot
chore(release): 1.9.0-dev.14 [skip ci]
ea184d0 
# [1.9.0-dev.14](v1.9.0-dev.13...v1.9.0-dev.14) (2024-05-18)

### Features

* **YouTube - Navigation buttons:** Add option to hide navigation button labels ([#635](#635)) ([6bd0ac2](6bd0ac2))
@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue May 18, 2024 that may be closed by this pull request
feat(YouTube): Hide navigation button labels ReVanced/revanced-patches#3187
Closed
3 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios removed a link to an issue May 18, 2024
feat(YouTube): Hide navigation button labels ReVanced/revanced-patches#3187
Closed
3 tasks
revanced-bot pushed a commit that referenced this pull request May 21, 2024
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
1b82e98 
# [1.9.0](v1.8.0...v1.9.0) (2024-05-21)

### Bug Fixes

* Use Java instead of Kotlin Regex to improve reliability ([#628](#628)) ([44c3cc4](44c3cc4))
* **YouTube - Client spoof:** Spoof client to fix playback ([#637](#637)) ([4c1f82a](4c1f82a))
* **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([75fa579](75fa579))
* **YouTube - Hide Shorts components:** Hide old layout like/dislike buttons without leaving empty space ([9782338](9782338))
* **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([#625](#625)) ([656ca17](656ca17))
* **YouTube - Hide video action buttons:** Remove obsolete `hide Shop button` ([#618](#618)) ([a78c3ff](a78c3ff))
* **YouTube - Hide video action buttons:** Updated path filter ([b74e544](b74e544))
* **YouTube - Player flyout menu:** Remove obsolete `Hide report menu` ([9e9d969](9e9d969))
* **YouTube - Restore old video quality menu:** Do not make click sounds when opening Shorts quality menu ([578a27d](578a27d))
* **YouTube - Restore old video quality menu:** Show advanced quality menu in Shorts quality flyout ([#632](#632)) ([77c9825](77c9825))
* **YouTube - Settings:** Use same background color for about screen if Theme patch is not included ([4164ed3](4164ed3))
* **YouTube - SponsorBlock:** Show correct segment times if video is over 24 hours in length ([#630](#630)) ([81251f9](81251f9))

### Features

* **YouTube - Comments:** Add option to hide timestamp and emoji buttons ([#621](#621)) ([6e9e122](6e9e122))
* **YouTube - Hide ads:** Add option to hide the 'Visit store' button on channel pages ([#622](#622)) ([9de566c](9de566c))
* **YouTube - Hide Shorts components:** Hide 'Buy super thanks' button ([#633](#633)) ([303754c](303754c))
* **YouTube - Hide Shorts components:** Hide like / dislike button in video ads ([#619](#619)) ([b2b6b8c](b2b6b8c))
* **YouTube - Navigation buttons:** Add option to hide navigation button labels ([#635](#635)) ([6bd0ac2](6bd0ac2))
E85Addict pushed a commit to E85Addict/revanced-integrations that referenced this pull request May 21, 2024
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
74316f2 
# [1.9.0](v1.8.0...v1.9.0) (2024-05-21)

### Bug Fixes

* Use Java instead of Kotlin Regex to improve reliability ([ReVanced#628](https://github.com/E85Addict/revanced-integrations/issues/628)) ([44c3cc4](44c3cc4))
* **YouTube - Client spoof:** Spoof client to fix playback ([ReVanced#637](https://github.com/E85Addict/revanced-integrations/issues/637)) ([4c1f82a](4c1f82a))
* **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([75fa579](75fa579))
* **YouTube - Hide Shorts components:** Hide old layout like/dislike buttons without leaving empty space ([9782338](9782338))
* **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([ReVanced#625](https://github.com/E85Addict/revanced-integrations/issues/625)) ([656ca17](656ca17))
* **YouTube - Hide video action buttons:** Remove obsolete `hide Shop button` ([ReVanced#618](https://github.com/E85Addict/revanced-integrations/issues/618)) ([a78c3ff](a78c3ff))
* **YouTube - Hide video action buttons:** Updated path filter ([b74e544](b74e544))
* **YouTube - Player flyout menu:** Remove obsolete `Hide report menu` ([9e9d969](9e9d969))
* **YouTube - Restore old video quality menu:** Do not make click sounds when opening Shorts quality menu ([578a27d](578a27d))
* **YouTube - Restore old video quality menu:** Show advanced quality menu in Shorts quality flyout ([ReVanced#632](https://github.com/E85Addict/revanced-integrations/issues/632)) ([77c9825](77c9825))
* **YouTube - Settings:** Use same background color for about screen if Theme patch is not included ([4164ed3](4164ed3))
* **YouTube - SponsorBlock:** Show correct segment times if video is over 24 hours in length ([ReVanced#630](https://github.com/E85Addict/revanced-integrations/issues/630)) ([81251f9](81251f9))

### Features

* **YouTube - Comments:** Add option to hide timestamp and emoji buttons ([ReVanced#621](https://github.com/E85Addict/revanced-integrations/issues/621)) ([6e9e122](6e9e122))
* **YouTube - Hide ads:** Add option to hide the 'Visit store' button on channel pages ([ReVanced#622](https://github.com/E85Addict/revanced-integrations/issues/622)) ([9de566c](9de566c))
* **YouTube - Hide Shorts components:** Hide 'Buy super thanks' button ([ReVanced#633](https://github.com/E85Addict/revanced-integrations/issues/633)) ([303754c](303754c))
* **YouTube - Hide Shorts components:** Hide like / dislike button in video ads ([ReVanced#619](https://github.com/E85Addict/revanced-integrations/issues/619)) ([b2b6b8c](b2b6b8c))
* **YouTube - Navigation buttons:** Add option to hide navigation button labels ([ReVanced#635](https://github.com/E85Addict/revanced-integrations/issues/635)) ([6bd0ac2](6bd0ac2))

### Performance Improvements

* Add upstream sync ([df18a17](df18a17))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcaDian @LisoUseInAIKyrios @oSumAtrIX