Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Hide seekbar): Seekbar turns red #2810

Closed
3 tasks done
98xe opened this issue Mar 3, 2024 · 2 comments · Fixed by #2804
Closed
3 tasks done

bug(YouTube - Hide seekbar): Seekbar turns red #2810

98xe opened this issue Mar 3, 2024 · 2 comments · Fixed by #2804
Labels
Bug report Something isn't working

Comments

@98xe
Copy link

98xe commented Mar 3, 2024

Bug description

When patched with Hide seekbar, the seekbar turns red when it should remain white (as it is in stock YouTube), even when the Theme patch is not included.

The Hide seekbar patch shouldn't have any effect on the seekbar's color.

Included patches:

  • GmsCore support
  • Hide seekbar

Error logs

No response

Solution

Excluding Hide seekbar fixes the issue.

Additional context

revanced-patches-4.3.0
YouTube v19.04.37

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@98xe 98xe added the Bug report Something isn't working label Mar 3, 2024
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Mar 3, 2024

@LisoUseInAIKyrios This relates to our past PR review: ReVanced/revanced-patches-template#2252 (comment)

I think the related line of code should've not been included:

@oSumAtrIX oSumAtrIX added the Prioritized Prioritization over other issues label Mar 3, 2024
@LisoUseInAIKyrios
Copy link
Contributor

The seekbar color patch is required for hiding the seekbar in the feed.

The solution is to change the integration Setting default value of custom seekbar color to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants