bug(YouTube - Hide ads): Hide fullscreen ads closes the app

[LisoUseInAIKyrios]

Bug description

When automatically closing a fullscreen ad (which simulates pressing the back button), instead of closing the ad the app is closed

Error logs

revanced: AdsFilter: Closing fullscreen ad

(no further ReVanced log entries, and the system logs shows the app closed successfully and did not crash)

Additional context

Reproduced with the latest dev release. Fullscreen ad that displayed for this situation was a fullscreen Premium signup.

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[LisoUseInAIKyrios]

Previously I have seen YT actually crash when displaying a full screen ad.

I did not save the logs, but it was not a ReVanced bug and instead it was Litho throwing an exception for something like an invalid layout parameter.

I can't remember, but I think version spoofing was turned on (or it was previously turned on and I did not clear the app data when turning spoofing off). I have not reproduce that crash ever since.

[oSumAtrIX]

I've seen others raising this issue as well. Possibly the patch triggers the back gesture at a point where it is not possible? I can not quite imagine how that can happen though. Reproduction steps would be necessary

[LisoUseInAIKyrios]

For me the problem showed up after using the 'Switching account' option in the 'You' tab.

But it only sometimes shows the full screen ad so it's difficult to reproduce.

[LisoUseInAIKyrios]

It looks like a different approach is needed that does not artificially pressing buttons.

For now, maybe change Hide Fullscreen ads to default off? Or remove the functionality completely until a better solution is found?

[johnconner122]

It's working fine for me. So it's better to set it to off by default instead of removing it.

[oSumAtrIX]

Instead of setting it to off, exceptions should be caught. Those who don't experience an issue will not be affected by the change

[LisoUseInAIKyrios]

Turns out my device also throws an exception for attempting to inject input events.

Maybe the app actually did crash for me in this issue, but somehow I overlooked that in the system log.

I tried adding android.permission.INJECT_EVENTS to the manifest and it still does not allow injecting a back button event. Then I found that permission was heavily restricted in Android 10 and requires the user to opt-in by manually turning on the permission in the settings.

[LisoUseInAIKyrios]

Closing this. As I now think this is the same issue as #2908