Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Can't back out of 'Get YouTube Premium' with back swipe or back button #3071

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Apr 22, 2024 · 13 comments
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Bug description

If the user goes into 'Get YouTube Premium' option in library and tries to back out by using the gesture control or by tapping the back arrow, the screen keeps looping back into it.
Screenshot_20240423_014240_YouTube

Screen_Recording_20240423_013752_YouTube.mp4

Error logs

No response

Solution

No response

Additional context

Spamming the back swipe/back button does seem to work but that's not the ideal solution.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Apr 22, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Apr 23, 2024

@ILoveOpenSourceApplications does this still happen if patched with only GmsCore support?

The back button behavior is changed by Hide ads and maybe it's causing this.

Does this menu appear in the litho logs?

@ILoveOpenSourceApplications
Copy link
Contributor Author

@ILoveOpenSourceApplications does this still happen if patched with only GmsCore support?

Yes.

The back button behavior is changed by Hide ads and maybe it's causing this.

If patched with GmsCore support only, the issue persists. So I goes no, it's not caused by Hide ads.

Does this menu appear in the litho logs?

I haven't tested that. I'll check and follow-up.

@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Apr 23, 2024

Litho logs after opening 'Get YouTube Premium'

04-23 14:35:54.378 15540 15720 D revanced: LithoFilterPatch: Searching ID: lp_empty_section.eml|96f658dcd6c06283 Path: lp_empty_section.eml|96f658dcd6c06283|CellType| BufferStrings: 1713863154027174935Γ¥Ölp_empty_section.eml|96f658dcd6c06283Γ¥Ö
04-23 14:35:54.382 15540 15720 D revanced: LithoFilterPatch: Searching ID: lp_section_group.eml-js-b|3614f991928f1cbc Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: lp_small_feature_group.eml|57624041f4e9a4e0Γ¥Ö1713863154027174939Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15720 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: lp_small_feature_group.eml|57624041f4e9a4e0Γ¥Ö1713863154027174939Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: lp_section_group.eml-js-b|3614f991928f1cbc Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType|ImageType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.383 15540 15720 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|lp_small_feature_group.eml|57624041f4e9a4e0|ContainerType| BufferStrings: lp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥ÖEX'kΓ¥Ö

@LisoUseInAIKyrios
Copy link
Contributor

What about the menu entry in the settings (the setting option that opens the problematic menu), is it in the litho logs?

@ILoveOpenSourceApplications
Copy link
Contributor Author

Screenshot_20240423_014240_YouTube

I couldn't capture any of the above options in library.

@LisoUseInAIKyrios
Copy link
Contributor

oddly, this has started working correctly for me.

Now the using the hardware back button or tapping the back icon correctly closes the prompt.

@ILoveOpenSourceApplications
Copy link
Contributor Author

No improvement on my end.

@oSumAtrIX
Copy link
Member

I am not able to reproduce the issue. Please check the same version of the unpatched app for this issue.

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Apr 23, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

There's no issue in the unpatched app. ReVanced YouTube v19.11.43 has the issue though on the other side.

@oSumAtrIX
Copy link
Member

If only GmsCore support patch was used I doubt ReVanced has anything to do with the issue. Switch accounts and reset app data to test for A/B.

@ILoveOpenSourceApplications
Copy link
Contributor Author

It could be an A/B testing. I downgraded back to v19.09.37 with GmsCore only, no issue. Upgraded to v19.10.39 GmsCore only, still no issue. Upgraded again back to 19.11.43 GmsCore only and still no issue. Patched again with patches that I use, and still no issue. So that sums it up.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

And now the issue is back :)

@ILoveOpenSourceApplications
Copy link
Contributor Author

I also noticed that, if the issue exists then when the user open the option the buffer icons refreshes twice before opening the setting. And it doesn't then there's no issue. A strange issue indeed.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants