Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Client spoof): Correctly play more livestreams using Android VR #3316

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jun 8, 2024

This fixes some livestreams that do not play with Android VR spoof.

A single call using GmsCore fails to playback Android VR livestreams in audio only, if the package name is spoofed.

Integration changes

@kazimmt
Copy link
Contributor

kazimmt commented Jun 9, 2024

@kitadai31 made something like that to select different spoof client for different video types for his Forked version of ReVanced patches for Android 6 & 7
image

Isn't it better than the current one we're using? (1 spoof client for all types of video)

@kitadai31
Copy link
Contributor

( @kazimmt That feature was ported from inotia00's ReVanced Extended)

@LisoUseInAIKyrios
Copy link
Contributor Author

If the last few issues of Android VR are solved (kids videos, random resuming), then there may no longer be a reason to set different spoofs for different video types.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit c05264a into ReVanced:dev Jun 9, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix_spoof_client_android_vr branch June 9, 2024 08:31
revanced-bot pushed a commit that referenced this pull request Jun 9, 2024
# [4.10.0-dev.5](v4.10.0-dev.4...v4.10.0-dev.5) (2024-06-09)

### Bug Fixes

* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([#3316](#3316)) ([c05264a](c05264a))
1fexd pushed a commit to 1fexd/revanced-patches-contrib that referenced this pull request Jun 13, 2024
# [4.10.0-dev.1](v4.9.0...v4.10.0-dev.1) (2024-06-13)

### Bug Fixes

* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b))

### Features

* Add allow app downgrading patch ([4f20cc9](4f20cc9))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
1fexd pushed a commit to 1fexd/revanced-patches-contrib that referenced this pull request Jun 13, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-13)

### Bug Fixes

* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b))

### Features

* Add allow app downgrading patch ([4f20cc9](4f20cc9))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
revanced-bot pushed a commit that referenced this pull request Jun 23, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([#3316](#3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([#3327](#3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3315](#3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3314](#3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([#3338](#3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([#3154](#3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([#3287](#3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([#3333](#3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([#3317](#3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([#3302](#3302)) ([5511736](5511736))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jun 23, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([5a86c70](5a86c70))
@kazimmt
Copy link
Contributor

kazimmt commented Jun 28, 2024

As it' take time to fix all side effects, I guess it's better to implement separate spoof for different video types.

E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jul 7, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-07-07)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([fc5b72d](fc5b72d))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jul 11, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-07-11)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([05677c9](05677c9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants